llvm_15: reenable libclang_rt.profile-....a build on musl#217042
Merged
yu-re-ka merged 1 commit intoNixOS:masterfrom Feb 19, 2023
yu-re-ka:musl-llvm-15-profile
Merged
llvm_15: reenable libclang_rt.profile-....a build on musl#217042yu-re-ka merged 1 commit intoNixOS:masterfrom yu-re-ka:musl-llvm-15-profile
yu-re-ka merged 1 commit intoNixOS:masterfrom
yu-re-ka:musl-llvm-15-profile
Conversation
This was most likely lost because of a bad merge
ofborg
bot
added
10.rebuild-darwin: 0
rrbutani
approved these changes
Feb 19, 2023
Contributor
There was a problem hiding this comment.
ahh, sorry, I bungled this in rrbutani@8c4b8b5; thanks for the fix!
Definitely doesn't need to be part of this PR or anything but it'd be great to have a regression test for this!
I'm not sure the best way to go about adding one though; @yu-re-ka do you generally notice errors like this because those compiler-rt files are missing or does this manifest as link errors when you try to use -fprofile-instr-generate or something similar?
Edit: nvm, just saw in your original PR that this gets tested as part of the pkgsMusl.firefox build.
rrbutani
added
the
12.approvals: 1
Contributor
Author
|
I notice this when I build pkgsMusl.firefox with PGO enabled |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was most likely lost because of a bad merge
Note how a few lines below it is already disabled for
useLLVM || bareMetal, so they get theCOMPILER_RT_BUILD_PROFILE=OFFflag twice.Change for LLVM 14 was in #191372
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)